From 1ce76f5a646883e8d78bd118b8c9819c8271eee9 Mon Sep 17 00:00:00 2001 From: Rotem Liss Date: Sun, 16 Sep 2007 03:38:37 +0000 Subject: [PATCH] Strike the link to the redirect rather than using an asterisk in Special:Listredirects --- RELEASE-NOTES | 1 + includes/SpecialListredirects.php | 15 +++++---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 37c5d780a8..f2f4978277 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -56,6 +56,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * Fix initial statistics when installing: add correct values * (bug 11342) Fix several 'returnto' links in permissions/error pages which linked to the main page instead of targetted page +* Strike the link to the redirect rather than using an asterisk in Special:Listredirects === API changes in 1.12 === diff --git a/includes/SpecialListredirects.php b/includes/SpecialListredirects.php index 581ea55b1f..92bd66e428 100644 --- a/includes/SpecialListredirects.php +++ b/includes/SpecialListredirects.php @@ -30,8 +30,7 @@ class ListredirectsPage extends QueryPage { # Make a link to the redirect itself $rd_title = Title::makeTitle( $result->namespace, $result->title ); - $arr = $wgContLang->getArrow() . $wgContLang->getDirMark(); - $rd_link = $skin->makeKnownLinkObj( $rd_title, '', 'redirect=no' ); + $rd_link = $skin->makeLinkObj( $rd_title, '', 'redirect=no' ); # Find out where the redirect leads $revision = Revision::newFromTitle( $rd_title ); @@ -39,19 +38,15 @@ class ListredirectsPage extends QueryPage { # Make a link to the destination page $target = Title::newFromRedirect( $revision->getText() ); if( $target ) { + $arr = $wgContLang->getArrow() . $wgContLang->getDirMark(); $targetLink = $skin->makeLinkObj( $target ); + return "$rd_link $arr $targetLink"; } else { - /** @todo Put in some decent error display here */ - $targetLink = '*'; + return "$rd_link"; } } else { - /** @todo Put in some decent error display here */ - $targetLink = '*'; + return "$rd_link"; } - - # Format the whole thing and return it - return "$rd_link $arr $targetLink"; - } } -- 2.20.1